Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test case catching the ConcurrentLister channel deadlock #7966

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mfoldenyi
Copy link

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@mfoldenyi mfoldenyi force-pushed the issue-7514-test-demo-failing branch from b700f0e to cc86791 Compare December 7, 2024 16:14
@mfoldenyi mfoldenyi force-pushed the issue-7514-test-demo-failing branch from cc86791 to 3ff6258 Compare December 7, 2024 16:15
@GiedriusS
Copy link
Member

Can we move this into #7933 to show that your fix fixes this issue?

@mfoldenyi
Copy link
Author

@GiedriusS I picked it into that one already:
https://github.com/thanos-io/thanos/pull/7933/commits

It is not the final commit as after it I still had some lint errors, as well as a bad id in the Changelog. (sha: 3f7b3aa)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants